Merge lp://staging/~coreygoldberg/window-mocker/py3 into lp://staging/window-mocker

129 +try:
130 + from StringIO import StringIO
131 +except ImportError:
132 + from io import StringIO
133 +
134 from mock import patch
135 -from StringIO import StringIO

We don't need to support py26 or earlier, so just import io.StringIO every time.

Otherwise, looks good

Note that io.StringIO insists on writing unicode objects only, so it does behave differently than StringIO.StringIO in Python 2.7. If window-mocker carefully converts everythign that's fine, but doing so will break the Python 3 support. So far I must say I avoid io.StringIO in code that supports both py 2 and 3 as it makes the code quite ugly (lots of "if sys.version" checks). But YMMV.

PASSED: Continuous integration, rev:25
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/3/rebuild

> so just import io.StringIO every time.

this is problematic due to Unicode handling.

> > so just import io.StringIO every time.
>
> this is problematic due to Unicode handling.

Hang on, it should make your life easier, not harder :)

Python 3 code needs clear separation of unicode vs byte strings. TBH, your python2 code should as well. If you want to deal with bytes, you can import 'io.BytesIO' instead. In my experience, using the older StringIO.StringIO class leads to problems down the line, since the behavior is remarkably different depending on what version of python you're running.

I guess if you're maintaining the code then that's fine, but I think this is going to cause you problems down the line :)

290 +
291 +
292 +

Too much whitespace (PEP8) :)

190 +# use Qt4 plugin for Python2, Qt5 plugin for Python3
191 +if sys.version_info[0] < 3:
192 + from windowmocker.plugins.qt4 import QtPlugin
193 +else:
194 + from windowmocker.plugins.qt5 import QtPlugin

Just thinking about our upgrade strategy here... If we do this, then the autopilot tests will need to be duplicated - one set of tests against Qt4, and another against Qt5 (because the introspection tree will be different - please correct me if I'm wrong here).

The Qt4 plugin should be importable in both python2 and python3, and should remain the default plugin.

The Qt5 plugin is only importable in python3, so we should make that plugin selectable, but only in python3 land.

Then we can port the autopilot tests that use window-mocker over, and we can explicitly ask for the Qt5 plugin, and either skip the tests in py2, or re-write them to work in py2/Qt4 as well.

However, following the above strategy will mean we don't break the AP tests once this gets merged.

PASSED: Continuous integration, rev:27
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/4/rebuild

PASSED: Continuous integration, rev:28
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/5/rebuild

Hi Corey,

There's still a few problems here. I grabbed your branch and built the package, but:

1) It only builds a python-windowmocker package, so there's no way to build & install the python3 variant.

2) If I run it from the source directly with:

PYTHONPATH=`pwd` python3 bin/window-mocker

then I get some python3 incompatibilities:

Traceback (most recent call last):
  File "bin/window-mocker", line 53, in <module>
    main()
  File "bin/window-mocker", line 25, in main
    application = create_application_from_data()
  File "/home/thomi/code/canonical/window-mocker/py3/windowmocker/__init__.py", line 83, in create_application_from_data
    if not isinstance(app_type_name, basestring):
NameError: global name 'basestring' is not defined

These two issues prevent me from testing this further. Please let me know once these have been fixed and I can look at it again.

FAILED: Continuous integration, rev:29
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/6/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/4/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/6/rebuild

FAILED: Continuous integration, rev:30
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/7/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/5/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/7/rebuild

FAILED: Continuous integration, rev:31
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/8/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/6/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/8/rebuild

PASSED: Continuous integration, rev:32
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/7

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/9/rebuild

FAILED: Continuous integration, rev:33
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/10/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/8/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/8/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/8/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/10/rebuild

FAILED: Continuous integration, rev:34
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/11/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/9/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/9/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/9/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/11/rebuild

FAILED: Continuous integration, rev:35
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/12/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/10/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/10/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/10/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/12/rebuild

FAILED: Continuous integration, rev:36
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/13/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/11/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/11/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/11/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/13/rebuild

FAILED: Continuous integration, rev:38
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/14/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/12/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/12/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/12/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/14/rebuild

FAILED: Continuous integration, rev:39
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/15/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/13/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/13/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/13/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/15/rebuild

FAILED: Continuous integration, rev:40
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/16/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/14/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/16/rebuild

PASSED: Continuous integration, rev:39
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/17/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/15

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/17/rebuild

PASSED: Continuous integration, rev:41
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/18/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/16

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/18/rebuild

bzr branch lp:~coreygoldberg/window-mocker/py3
cd py3
bzr bd
sudo dpkg -i ../build-area/*.deb

Does not work, because the .desktop files collide. You need to fix them like you had to fix the executable scripts.

Please make sure that, at a minimum, you can build the packages, install them, and the installed executables work before resubmitting for a review.

PASSED: Continuous integration, rev:42
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/19/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/17
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/17
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/17

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/19/rebuild

packages build now.

note.. when running `window-mocker`, i get the following output to console:

"No handlers could be found for logger "windowmocker.plugins.base""

when running `window-mocker3`, I don't get that debug output.

Hi Corey,

Selecting the Qt5 plugin doesn't work. I expect:

window-mocker3 -t Qt4

to launch a Qt4 window, and:

window-mocker3 -t Qt5

to launch a Qt5 window.

At the moment they both launch a Qt4 window.

PASSED: Continuous integration, rev:43
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/20/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/18
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/18
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/18

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/20/rebuild

Hi,

The latest revision includes several defects:

1) Running 'window-mocker' just produces an error and exits:

$ window-mocker
ERROR:windowmocker.plugins:No plugin was found with name '<function get_default_plugin_name at 0x1618398>'
Error: Unable to process request: Type name '<function get_default_plugin_name at 0x1618398>' is invalid

2) Running 'window-mocker3' produces similar errors:

$ window-mocker3
ERROR:windowmocker.plugins:No plugin was found with name '<function get_default_plugin_name at 0x7f90a55847a0>'
Error: Unable to process request: Type name '<function get_default_plugin_name at 0x7f90a55847a0>' is invalid

For both points 1) and 2), the desired behavior is that it should just open the window with the default plugin (qt4 in both cases).

3) Running 'window-mocker -h' lists the 'Qt5' plugin as an available option, but that's incorrect - Qt5 is not available in python 2. If you try and actually run it in this configuration, it crashes:

$ window-mocker -t Qt5
Traceback (most recent call last):
  File "/usr/bin/window-mocker", line 54, in <module>
    main()
  File "/usr/bin/window-mocker", line 25, in main
    application = create_application_from_data(app_type_name=args.type)
  File "/usr/lib/python2.7/dist-packages/windowmocker/__init__.py", line 88, in create_application_from_data
    app_instance = app_plugin(data)
  File "/usr/lib/python2.7/dist-packages/windowmocker/plugins/__init__.py", line 20, in create_qt5_plugin
    from windowmocker.plugins.qt5 import QtPlugin as Qt5Plugin
  File "/usr/lib/python2.7/dist-packages/windowmocker/plugins/qt5.py", line 10, in <module>
    from PyQt5 import QtCore, QtWidgets
ImportError: No module named PyQt5

The Qt4 plugin should not be listed as an option in python2.

4) Running 'window-mocker3 -t Qt5' does indeed produce a Qt5 window (yay!), but closing that window causes window-mocker3 to crash (segfault, in fact, which is impressive, for a python application).

Given that these regressed, it's probably a good idea to add functional tests for all these issues before fixing them.

PASSED: Continuous integration, rev:44
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/21/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/19

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/21/rebuild

PASSED: Continuous integration, rev:45
http://jenkins.qa.ubuntu.com/job/window-mocker-ci/22/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-amd64-ci/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-armhf-ci/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/window-mocker-trusty-i386-ci/20

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/window-mocker-ci/22/rebuild

Apologies for not seeing this mp first, but I have a competing mp:

https://code.launchpad.net/~barry/window-mocker/py3/+merge/204237

I'll take a look at Corey's branch and see if mine is missing anything. I don't have much of an opinion about PyQt4/PyQt5, but I have a strong opinion that window-mocker should only be Python 3. We don't want to B-D or Depend on any Python 2 related packages. Let's get rid of them once and for all. AFAICT, this is used as an application, not a library, so it doesn't need to be bilingual, and we definitely don't want to carry those extra dependencies. It also simplifies the code.

As for Qt4/5, what's the use case for letting that be switchable, other than the bug mentioned in my mp (which I can't reproduce here locally)? It should be hard to switch back to PyQt4, but OTOH PyQt5 works okay for me (and it passes all the tests <wink>). Does it need to be switchable, or can it be one or the other? OTOH, I don't care too much since both work in Python 3. :)

Approving, since the Qt5 crash has been tracked down to another module. Let's land this!