Code review comment for lp://staging/~clint-fewbar/ubuntu/maverick/php5/fix-mssql-segfault

Revision history for this message
Barry Warsaw (barry) wrote :

Hi Clint, great work on following up with this bug. While your patch is certainly reasonable, it differs from what upstream applied: http://svn.php.net/viewvc/php/php-src/trunk/ext/mssql/php_mssql.c?r1=303375&r2=303374&pathrev=303375

Would it make more sense to use their change for consistency? It's also a somewhat simpler change (and probably what I would have done :).

review: Needs Fixing

« Back to merge proposal