Merge lp://staging/~clint-fewbar/ubuntu/maverick/php5/fix-mssql-segfault into lp://staging/ubuntu/maverick/php5

Proposed by Clint Byrum
Status: Work in progress
Proposed branch: lp://staging/~clint-fewbar/ubuntu/maverick/php5/fix-mssql-segfault
Merge into: lp://staging/ubuntu/maverick/php5
Diff against target: 56 lines (+36/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/mssql_fix_segfault.patch (+28/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~clint-fewbar/ubuntu/maverick/php5/fix-mssql-segfault
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Needs Fixing
Review via email: mp+35476@code.staging.launchpad.net

Description of the change

Fixes segfault, tested on maverick.

To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

Hi Clint, great work on following up with this bug. While your patch is certainly reasonable, it differs from what upstream applied: http://svn.php.net/viewvc/php/php-src/trunk/ext/mssql/php_mssql.c?r1=303375&r2=303374&pathrev=303375

Would it make more sense to use their change for consistency? It's also a somewhat simpler change (and probably what I would have done :).

review: Needs Fixing
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Funny, I just noticed yesterday that upstream had patched it in a different and more elegant way.

I'll update the MP ASAP, thanks for the review Barry!

Unmerged revisions

72. By Clint Byrum

debian/patches/mssql-fix-segfault.patch: Fixes segfault on missing parameters
for mssql. upstream php bug #52843 and (LP: #611316)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: