Code review comment for lp://staging/~cldunlap1/ubuntu/oneiric/xine-lib/fix-for-835437

On Friday, October 07, 2011 05:26:31 AM you wrote:
> Review: Needs Fixing
>
> Thanks Chad about this fixes and attention to detail. It's small improvment
> like that which makes ubuntu better! :-)
>
> However, I need to disapprove that change for now:
> - all changes are done inline, you need rather to use a patch system like
> quilt (which is already used in the package):
> https://wiki.ubuntu.com/PackagingGuide/Howtos/Quilt - this change clearly
> need to be done upstream to benefit all users of xine and not just ubuntu
> one. Can you please upstream this? If you need more help on how to do
> that, do not hesitate to ping me on irc (didrocks)!

I have made the changes per your request and uploaded them. I am going to
try and figure out how to push this upstream now.

Thank you for pointing out the errors, it was quite the learning experience.

--

Thank You,
Chad Dunlap