Merge lp://staging/~cldunlap1/ubuntu/oneiric/xine-lib/fix-for-835437 into lp://staging/ubuntu/oneiric/xine-lib

Thanks Chad about this fixes and attention to detail. It's small improvment like that which makes ubuntu better! :-)

However, I need to disapprove that change for now:
- all changes are done inline, you need rather to use a patch system like quilt (which is already used in the package): https://wiki.ubuntu.com/PackagingGuide/Howtos/Quilt
- this change clearly need to be done upstream to benefit all users of xine and not just ubuntu one. Can you please upstream this? If you need more help on how to do that, do not hesitate to ping me on irc (didrocks)!

On Friday, October 07, 2011 05:26:31 AM you wrote:
> Review: Needs Fixing
>
> Thanks Chad about this fixes and attention to detail. It's small improvment
> like that which makes ubuntu better! :-)
>
> However, I need to disapprove that change for now:
> - all changes are done inline, you need rather to use a patch system like
> quilt (which is already used in the package):
> https://wiki.ubuntu.com/PackagingGuide/Howtos/Quilt - this change clearly
> need to be done upstream to benefit all users of xine and not just ubuntu
> one. Can you please upstream this? If you need more help on how to do
> that, do not hesitate to ping me on irc (didrocks)!

I have made the changes per your request and uploaded them. I am going to
try and figure out how to push this upstream now.

Thank you for pointing out the errors, it was quite the learning experience.

--

Thank You,
Chad Dunlap

On Friday, October 07, 2011 05:26:31 AM you wrote:
> Review: Needs Fixing
>
> Thanks Chad about this fixes and attention to detail. It's small improvment
> like that which makes ubuntu better! :-)
>
> However, I need to disapprove that change for now:
> - all changes are done inline, you need rather to use a patch system like
> quilt (which is already used in the package):
> https://wiki.ubuntu.com/PackagingGuide/Howtos/Quilt - this change clearly
> need to be done upstream to benefit all users of xine and not just ubuntu
> one. Can you please upstream this? If you need more help on how to do
> that, do not hesitate to ping me on irc (didrocks)!

here is the link, I think, you wanted for the upstream bug report.

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=644927

If it isn't, please let me know.
--

Thank You,
Chad Dunlap

Thanks Chad. Your fixes were applied upstream, so they will trickle into Ubuntu with the next version. I don't think it's worth making a separate upload for those (also, this needs to be quilt-ified, etc.).