Code review comment for lp://staging/~cjohnston/qa-dashboard/remove-code-goodness

The attempt to merge lp:~chrisjohnston/qa-dashboard/remove-code-goodness into lp:qa-dashboard failed. Below is the output from the failed tests.

Creating test database for alias 'default'...
Destroying test database for alias 'default'...

..................................................................................................................EEEEEEE
======================================================================
ERROR: test_image_details (bootspeed.tests.TestBootspeedAPI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 74, in test_image_details
    data = self._get_object_list(object_type="image")
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 54, in _get_object_list
    return self._get_json_data(url)
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 41, in _get_json_data
    f = urllib2.urlopen(url)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 111] Connection refused>

======================================================================
ERROR: test_image_list (bootspeed.tests.TestBootspeedAPI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 67, in test_image_list
    data = self._get_object_list(object_type="image")
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 54, in _get_object_list
    return self._get_json_data(url)
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 41, in _get_json_data
    f = urllib2.urlopen(url)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 111] Connection refused>

======================================================================
ERROR: test_image_result_list (bootspeed.tests.TestBootspeedAPI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 128, in test_image_result_list
    data = self._get_object_list(object_type="image")
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 54, in _get_object_list
    return self._get_json_data(url)
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 41, in _get_json_data
    f = urllib2.urlopen(url)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 111] Connection refused>

======================================================================
ERROR: test_invalid_image_details (bootspeed.tests.TestBootspeedAPI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 91, in test_invalid_image_details
    self._get_object_details(image_id, object_type="image")
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 61, in _get_object_details
    return self._get_json_data(url)
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 41, in _get_json_data
    f = urllib2.urlopen(url)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 111] Connection refused>

======================================================================
ERROR: test_invalid_machine_details (bootspeed.tests.TestBootspeedAPI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 121, in test_invalid_machine_details
    self._get_object_details(machine_id, object_type="machine")
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 61, in _get_object_details
    return self._get_json_data(url)
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 41, in _get_json_data
    f = urllib2.urlopen(url)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 111] Connection refused>

======================================================================
ERROR: test_machine_details (bootspeed.tests.TestBootspeedAPI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 104, in test_machine_details
    data = self._get_object_list(object_type="machine")
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 54, in _get_object_list
    return self._get_json_data(url)
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 41, in _get_json_data
    f = urllib2.urlopen(url)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 111] Connection refused>

======================================================================
ERROR: test_machine_list (bootspeed.tests.TestBootspeedAPI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 97, in test_machine_list
    data = self._get_object_list(object_type="machine")
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 54, in _get_object_list
    return self._get_json_data(url)
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 41, in _get_json_data
    f = urllib2.urlopen(url)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 111] Connection refused>

----------------------------------------------------------------------
Ran 121 tests in 3.290s

FAILED (errors=7)