Ubuntu CI Dashboard

Merge lp://staging/~cjohnston/qa-dashboard/remove-code-goodness into lp://staging/qa-dashboard

  1. remove-code-goodness
  2. Merge into dev
Proposed by Chris Johnston
Status: Merged
Approved by: Joe Talbott
Approved revision: 184
Merged at revision: 179
Proposed branch: lp://staging/~cjohnston/qa-dashboard/remove-code-goodness
Merge into: lp://staging/qa-dashboard
Diff against target: 1124 lines (+139/-689)
15 files modified
bootspeed/api.py (+14/-73)
bootspeed/models.py (+5/-1)
bootspeed/tables.py (+1/-5)
bootspeed/tests.py (+0/-111)
bootspeed/views.py (+16/-7)
dashboard/management/commands/jenkins_pull.py (+9/-1)
dashboard/management/commands/jenkins_pull_sru.py (+9/-1)
dashboard/tests.py (+0/-88)
dashboard/views/api/__init__.py (+0/-36)
dashboard/views/api/smoke.py (+0/-121)
dashboard/views/api/sru.py (+0/-117)
pylint.rc (+83/-0)
qa_dashboard/urls.py (+1/-5)
requirements.txt (+1/-0)
tests/test_bootspeed_api.py (+0/-123)
To merge this branch: bzr merge lp://staging/~cjohnston/qa-dashboard/remove-code-goodness
Reviewer Review Type Date Requested Status
Joe Talbott Approve
Review via email: mp+139608@code.staging.launchpad.net

Commit message

Code removal and pylint cleanup

Description of the change

* Starts removing unneeded code
* Starts using pylint

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) wrote :

Looks good. Sad to see so much code getting ripped out but it's nice to be neat and concise. Thanks

review: Approve
Revision history for this message
Chris Johnston (cjohnston) wrote :
Download full text (9.0 KiB)

The attempt to merge lp:~chrisjohnston/qa-dashboard/remove-code-goodness into lp:qa-dashboard failed. Below is the output from the failed tests.

Creating test database for alias 'default'...
Destroying test database for alias 'default'...

..................................................................................................................EEEEEEE
======================================================================
ERROR: test_image_details (bootspeed.tests.TestBootspeedAPI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 74, in test_image_details
    data = self._get_object_list(object_type="image")
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 54, in _get_object_list
    return self._get_json_data(url)
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 41, in _get_json_data
    f = urllib2.urlopen(url)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 111] Connection refused>

======================================================================
ERROR: test_image_list (bootspeed.tests.TestBootspeedAPI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 67, in test_image_list
    data = self._get_object_list(object_type="image")
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 54, in _get_object_list
    return self._get_json_data(url)
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 41, in _get_json_data
    f = urllib2.urlopen(url)
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 400, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 418, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 111] Connection refused>

======================================================================
ERROR: test_image_result_list (bootspeed.tests.TestBootspeedAPI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/dataset-1/tarmac/dash/bootspeed/tests.py", line 128, in test_image_result_list
    data = self._get_object_l...

Read more...

lp://staging/~cjohnston/qa-dashboard/remove-code-goodness updated
184. By Chris Johnston

Removing more invalid code

Revision history for this message
Joe Talbott (joetalbott) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches