Code review comment for lp://staging/~chipaca/ubuntuone-client/connect-on-startup-maybe
Revision history for this message
| John Lenton (chipaca) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
On Wed, Mar 31, 2010 at 03:20:09PM -0000, Rodney Dawes wrote:
> Review: Needs Fixing
> Personally, I would avoid using twisted here, as there's no need for it. The glib main loop would suffice.
>
> However, given that the script is poking at the keyring, you should also add the necessary bits to the data files, so that it gets added to the keyring acl when a token is gotten, to avoid popping up the keyring access when the user logs in. But once the keyring acls data is updated here, I'll approve. :)
fixed, I think :)