Merge lp://staging/~chipaca/ubuntuone-client/connect-on-startup-maybe into lp://staging/ubuntuone-client

Personally, I would avoid using twisted here, as there's no need for it. The glib main loop would suffice.

However, given that the script is poking at the keyring, you should also add the necessary bits to the data files, so that it gets added to the keyring acl when a token is gotten, to avoid popping up the keyring access when the user logs in. But once the keyring acls data is updated here, I'll approve. :)

On Wed, Mar 31, 2010 at 03:20:09PM -0000, Rodney Dawes wrote:
> Review: Needs Fixing
> Personally, I would avoid using twisted here, as there's no need for it. The glib main loop would suffice.
>
> However, given that the script is poking at the keyring, you should also add the necessary bits to the data files, so that it gets added to the keyring acl when a token is gotten, to avoid popping up the keyring access when the user logs in. But once the keyring acls data is updated here, I'll approve. :)

fixed, I think :)

Oh. Also, the ubuntuone-launch.desktop.in should have Icon=ubuntuone added to it. :)

Approved. Removed ubuntuone-* packages and then installed John's branch (copying bin/ubuntuone-syncdaemon to /usr/libexec/). Restarted and waited 30 seconds. Ran u1sdtool -s and saw I was connected and syncdaemon was doing its thing. Also did the same test without a u1 token and got the expected results: nothing happens. :)

I don't know much about the client's architecture, just a couple Twisted-related comments.

1) Nothing seems to involve Twisted's reactor, are deferreds going to work even without it?

2) I'm not familiar with the idiom of firing a deferred *before* hooking up callbacks and errbacks. It might work, but then why use deferreds at all?

I must be missing something. :-)

Hi,

Nicola,

Deferreds should work without the reactor, and in this case the deferred callback/errback is triggered by a dbus reply/error handler.

John,
/me really likes the inlineCallbacks version