Code review comment for lp://staging/~canonical-platform-qa/ubuntu-power-tests/initial-commit-of-existing

Revision history for this message
Max Brustkern (nuclearbob) wrote :

> Some thoughts and ideas. Probably not needed to get this first import landed,
> maybe should be broken into cards and handled piece by piece.
>
> Thoughts:
> - Filler needs to be removed from d/* files (changelog, control, copyright
> etc.)

Agreed. I'll make a card for this.

>
> - Readme: Probably should mention what (if anything) can be run without the
> metre/measurement equipment etc.

I'll give myself a task to clarify this.

>
> Regarding the powerd-cli issue and adt messing around with it, perhaps we can
> fork and use our own adb-ssh script until we can get something merged into
> autopkgtest. We do this with the OTA tests, see the script here [1] and it's
> use here[2]
>
> [1] http://bazaar.launchpad.net/~canonical-platform-qa/ubuntu-ota-
> tests/trunk/view/head:/adb-reboot-to-recovery
> [2] http://bazaar.launchpad.net/~canonical-platform-qa/ubuntu-ota-
> tests/trunk/view/head:/README.rst#L25

Federico's branch does that. I think that's a good idea for this sprint, but I'd really like us to get upstream support so we don't carry a diff. I want us current on all the changes in adt since it's so critical.

« Back to merge proposal