ubuntu-power-tests

Merge lp://staging/~canonical-platform-qa/ubuntu-power-tests/initial-commit-of-existing into lp://staging/ubuntu-power-tests

  1. initial-commit-of-existing
  2. Merge into trunk
Proposed by Christopher Lee
Status: Merged
Merged at revision: 6
Proposed branch: lp://staging/~canonical-platform-qa/ubuntu-power-tests/initial-commit-of-existing
Merge into: lp://staging/ubuntu-power-tests
Diff against target: 562 lines (+451/-0)
21 files modified
.bzrignore (+1/-0)
README (+74/-0)
custom-tarball/custom.tar.xz.README (+1/-0)
custom-tarball/disable-gpg (+5/-0)
debian/changelog (+5/-0)
debian/compat (+1/-0)
debian/control (+13/-0)
debian/copyright (+22/-0)
debian/install (+1/-0)
debian/rules (+32/-0)
debian/source/format (+1/-0)
debian/tests/control (+3/-0)
debian/tests/tc-powermeter-01 (+3/-0)
debian/tests/tc-powermeter-02 (+9/-0)
debian/tests/tc-powermeter-03 (+15/-0)
power-meter-tests/logdata.sh (+40/-0)
power-meter-tests/spread.py (+6/-0)
power-meter-tests/statparse.py (+87/-0)
power-meter-tests/test.sh (+86/-0)
power-meter-tests/test_display-on.sh (+2/-0)
power-meter-tests/test_upload.sh (+44/-0)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/ubuntu-power-tests/initial-commit-of-existing
Reviewer Review Type Date Requested Status
Federico Gimenez (community) Approve
Christopher Lee (community) Approve
Review via email: mp+254850@code.staging.launchpad.net

Commit message

Initial commit under stand along project name.

Description of the change

Initial commit under stand along project name.
Also provides the chance for a review and comments.

To post a comment you must log in.
Revision history for this message
Christopher Lee (veebers) wrote :

Some thoughts and ideas. Probably not needed to get this first import landed, maybe should be broken into cards and handled piece by piece.

Thoughts:
  - Filler needs to be removed from d/* files (changelog, control, copyright etc.)

  - Readme: Probably should mention what (if anything) can be run without the metre/measurement equipment etc.

Regarding the powerd-cli issue and adt messing around with it, perhaps we can fork and use our own adb-ssh script until we can get something merged into autopkgtest. We do this with the OTA tests, see the script here [1] and it's use here[2]

[1] http://bazaar.launchpad.net/~canonical-platform-qa/ubuntu-ota-tests/trunk/view/head:/adb-reboot-to-recovery
[2] http://bazaar.launchpad.net/~canonical-platform-qa/ubuntu-ota-tests/trunk/view/head:/README.rst#L25

Revision history for this message
Max Brustkern (nuclearbob) wrote :

> Some thoughts and ideas. Probably not needed to get this first import landed,
> maybe should be broken into cards and handled piece by piece.
>
> Thoughts:
> - Filler needs to be removed from d/* files (changelog, control, copyright
> etc.)

Agreed. I'll make a card for this.

>
> - Readme: Probably should mention what (if anything) can be run without the
> metre/measurement equipment etc.

I'll give myself a task to clarify this.

>
> Regarding the powerd-cli issue and adt messing around with it, perhaps we can
> fork and use our own adb-ssh script until we can get something merged into
> autopkgtest. We do this with the OTA tests, see the script here [1] and it's
> use here[2]
>
> [1] http://bazaar.launchpad.net/~canonical-platform-qa/ubuntu-ota-
> tests/trunk/view/head:/adb-reboot-to-recovery
> [2] http://bazaar.launchpad.net/~canonical-platform-qa/ubuntu-ota-
> tests/trunk/view/head:/README.rst#L25

Federico's branch does that. I think that's a good idea for this sprint, but I'd really like us to get upstream support so we don't carry a diff. I want us current on all the changes in adt since it's so critical.

Revision history for this message
Federico Gimenez (fgimenez) wrote :

Some inline comments, thanks!

lp://staging/~canonical-platform-qa/ubuntu-power-tests/initial-commit-of-existing updated
3. By Max Brustkern

Added custom tarball files and info

4. By Max Brustkern

Updated README

5. By Max Brustkern

Addressed additional merge concerns

Revision history for this message
Christopher Lee (veebers) wrote :

Looking good. 1 minor comment inline, but shouldn't stop a merge/approve.

I would be happy to suggest we merge this as is and put any outstanding comments as cards against this project.

review: Approve
Revision history for this message
Federico Gimenez (fgimenez) wrote :

LGTM

review: Approve
lp://staging/~canonical-platform-qa/ubuntu-power-tests/initial-commit-of-existing updated
6. By Max Brustkern

Last minor concerns before initial merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: