I approve without a successful device run. I cannot make trunk nor this branch run successfully; instead it suffers from issue of hanging during credentials creation.
Anyways, on the MP itself launch_ubuntu_app and related methods should be rolled into a helper or even autopilot. This can serve as a testbed in the interim. Once you add back home patching on click I would be keen to see how we can appropriately bring app launching to the core apps. I'm keen to not overload too much into the UITK helpers, as I feel like some of this functionality is core to click apps and should be rolled into autopilot itself (otherwise, we would NEVER tell someone to use launch_test_click via autopilot, which would not be healthy).
I approve without a successful device run. I cannot make trunk nor this branch run successfully; instead it suffers from issue of hanging during credentials creation.
Anyways, on the MP itself launch_ubuntu_app and related methods should be rolled into a helper or even autopilot. This can serve as a testbed in the interim. Once you add back home patching on click I would be keen to see how we can appropriately bring app launching to the core apps. I'm keen to not overload too much into the UITK helpers, as I feel like some of this functionality is core to click apps and should be rolled into autopilot itself (otherwise, we would NEVER tell someone to use launch_test_click via autopilot, which would not be healthy).