Merge lp://staging/~canonical-platform-qa/reminders-app/fix1363599-upstart_and_sandbox into lp://staging/reminders-app

FAILED: Continuous integration, rev:246
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/reminders-app/fix1363599-upstart_and_sandbox/+merge/233832/+edit-commit-message

http://91.189.93.70:8080/job/reminders-app-ci/502/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1951/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/198/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/502/rebuild

FAILED: Continuous integration, rev:247
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/reminders-app/fix1363599-upstart_and_sandbox/+merge/233832/+edit-commit-message

http://91.189.93.70:8080/job/reminders-app-ci/503/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1953
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1953/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/199

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/503/rebuild

FAILED: Continuous integration, rev:249
http://91.189.93.70:8080/job/reminders-app-ci/504/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1954
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1954/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/200

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/504/rebuild

Comments inline

PASSED: Continuous integration, rev:250
http://91.189.93.70:8080/job/reminders-app-ci/507/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1964
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1964/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/203

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/507/rebuild

PASSED: Continuous integration, rev:251
http://91.189.93.70:8080/job/reminders-app-ci/508/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1965
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1965/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/204

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/508/rebuild

Does test_go_to_account_settings still need to be skipped?

I would setup the BaseTestCaseWithTempHome differently. In setUp, I would set:

self.launcher, self.test_type = self.get_launcher_and_type()

Then for RemindersAppTestCase,

    def setUp(self):
        super(RemindersAppTestCase, self).setUp()
        self.app = reminders.RemindersApp(self.launcher(), self.test_type)

Of course, your __init__() method should also include test_type.

I noticed you referenced https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1329141; I wonder if this is causing some of the random fails we see other places (music and filemanager both use random names amongst others perhaps).

> Does test_go_to_account_settings still need to be skipped?

Reported that one as bug 1367784.

> I would setup the BaseTestCaseWithTempHome differently. In setUp, I would set:
>
> self.launcher, self.test_type = self.get_launcher_and_type()
>
> Then for RemindersAppTestCase,
>
> def setUp(self):
> super(RemindersAppTestCase, self).setUp()
> self.app = reminders.RemindersApp(self.launcher(), self.test_type)
>
> Of course, your __init__() method should also include test_type.

This is the pattern I discussed with Victor, using a launcher fixture:
https://code.launchpad.net/~canonical-platform-qa/ubuntu-system-settings-online-accounts/launch_fixture/+merge/226851

Please take a look and leave your comments. I'm making a note to do the same for reminders and ask for your review.

> I noticed you referenced https://bugs.launchpad.net/ubuntu-ui-
> toolkit/+bug/1329141; I wonder if this is causing some of the random fails we
> see other places (music and filemanager both use random names amongst others
> perhaps).

The bug is worked around on the toolkit. It could affect other apps only if they are not using the toolkit helpers, which I don't think it's happening. Only on unity and on the toolkit, and now on reminders, we create test desktop files afaik.

FAILED: Continuous integration, rev:253
http://91.189.93.70:8080/job/reminders-app-ci/509/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1969/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/205/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/509/rebuild

PASSED: Continuous integration, rev:254
http://91.189.93.70:8080/job/reminders-app-ci/510/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1970
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1970/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/206

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/510/rebuild

I approve without a successful device run. I cannot make trunk nor this branch run successfully; instead it suffers from issue of hanging during credentials creation.

Anyways, on the MP itself launch_ubuntu_app and related methods should be rolled into a helper or even autopilot. This can serve as a testbed in the interim. Once you add back home patching on click I would be keen to see how we can appropriately bring app launching to the core apps. I'm keen to not overload too much into the UITK helpers, as I feel like some of this functionality is core to click apps and should be rolled into autopilot itself (otherwise, we would NEVER tell someone to use launch_test_click via autopilot, which would not be healthy).