Code review comment for lp://staging/~canonical-isd-hackers/canonical-identity-provider/password-db-entry-missing

Revision history for this message
Łukasz Czyżykowski (lukasz-czyzykowski) wrote :

- why in test_authenticate_account_no_password you're getting object again? looks like this was asserted in the beginning of the test

- in test_reset_password_when_account_{active, active_no_password} I would rather see account.status = AccountStatus.ACTIVE; account.save() instead of the assert, as this more in line of what is checked in those tests

- I feel that the logic in views.ui for accessing account password should be moved to account model

« Back to merge proposal