Canonical SSO provider

Merge lp://staging/~canonical-isd-hackers/canonical-identity-provider/password-db-entry-missing into lp://staging/canonical-identity-provider/release

password-db-entry-missing
Merge into trunk

Proposed by Szilveszter Farkas on 2010-05-10

Status:	Merged
Approved by:	Danny Tamez on 2010-05-12
Approved revision:	no longer in the source branch.
Merged at revision:	17
Proposed branch:	lp://staging/~canonical-isd-hackers/canonical-identity-provider/password-db-entry-missing
Merge into:	lp://staging/canonical-identity-provider/release
Diff against target:	423 lines (+123/-122) 5 files modified identityprovider/auth.py (+7/-2) identityprovider/models/account.py (+2/-1) identityprovider/tests/test_auth.py (+10/-0) identityprovider/tests/test_views_ui.py (+95/-116) identityprovider/views/ui.py (+9/-3)
To merge this branch:	bzr merge lp://staging/~canonical-isd-hackers/canonical-identity-provider/password-db-entry-missing
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Łukasz Czyżykowski (community)		2010-05-10	Approve on 2010-05-11
Review via email: mp+25001@code.staging.launchpad.net

Revision history for this message

Łukasz Czyżykowski (lukasz-czyzykowski) wrote on 2010-05-11:

- why in test_authenticate_account_no_password you're getting object again? looks like this was asserted in the beginning of the test

- in test_reset_password_when_account_{active, active_no_password} I would rather see account.status = AccountStatus.ACTIVE; account.save() instead of the assert, as this more in line of what is checked in those tests

- I feel that the logic in views.ui for accessing account password should be moved to account model

Revision history for this message

Szilveszter Farkas (phanatic) wrote on 2010-05-11:

1) I wanted to make sure that the Account object isn't deleted (there's a OneToOne relationship between Account and AccountPassword).

2) That's something not introduced by my changes, but I'm happy to change that.

3) We discussed that on IRC.

Revision history for this message

Łukasz Czyżykowski (lukasz-czyzykowski) wrote on 2010-05-11:

As we discussed on IRC, there's no clean way of fixing that in Django and current db schema.

review: Approve