I don't see review feedback incorporated. Did you push the right branch? I'm looking at efea26f. Here are the changes I see against what I reviewed previously:
$ git range-diff d358c19..bryce/sendmail-object.v1 9e8e5da..bryce/sendmail-object
1: bb91757 = 1: 88a6898 Refactor importer to encapsulate sendmail logic to its own object
2: 6e038ff = 2: 4a546e4 Send fewer package import/failure emails
3: b361f4b ! 3: efea26f systemd: Include last 100 lines from journal in system failure emails
@@ -2,6 +2,11 @@
systemd: Include last 100 lines from journal in system failure emails
+ Log errors from this script to the journal as well.
+
+ Also, drop unnecessary User/Group settings in service, since this runs
+ fine as the current (non-root) user.
+
diff --git a/bin/failure-email.sh b/bin/failure-email.sh
--- a/bin/failure-email.sh
+++ b/bin/failure-email.sh
@@ -19,3 +24,17 @@
+$(journalctl --unit=usd-importer.service -n 100 --no-pager)
EOF
I don't see review feedback incorporated. Did you push the right branch? I'm looking at efea26f. Here are the changes I see against what I reviewed previously:
$ git range-diff d358c19. .bryce/ sendmail- object. v1 9e8e5da. .bryce/ sendmail- object
1: bb91757 = 1: 88a6898 Refactor importer to encapsulate sendmail logic to its own object
2: 6e038ff = 2: 4a546e4 Send fewer package import/failure emails
3: b361f4b ! 3: efea26f systemd: Include last 100 lines from journal in system failure emails
@@ -2,6 +2,11 @@
systemd: Include last 100 lines from journal in system failure emails
+ Log errors from this script to the journal as well. email.sh b/bin/failure- email.sh email.sh email.sh usd-importer. service -n 100 --no-pager)
+
+ Also, drop unnecessary User/Group settings in service, since this runs
+ fine as the current (non-root) user.
+
diff --git a/bin/failure-
--- a/bin/failure-
+++ b/bin/failure-
@@ -19,3 +24,17 @@
+$(journalctl --unit=
EOF
+ failure- email@. service b/usd-importer- failure- email@. service failure- email@. service failure- email@. service =/snap/ git-ubuntu/ current/ bin/failure- email.sh %i systemd- journal =/bin/bash /snap/git- ubuntu/ current/ bin/failure- email.sh %i utput=journal
+diff --git a/usd-importer-
+--- a/usd-importer-
++++ b/usd-importer-
+@@
+
+ [Service]
+ Type=oneshot
+-ExecStart
+-User=nobody
+-Group=
++ExecStart
++StandardO
++