Code review comment for lp://staging/~brian-murray/daisy/bugs-to-crash-sig

Revision history for this message
Evan (ev) wrote :

This looks good, save one small issue that I'll fix after merging:

+ bug = int(data.get('CreatedBug', ''))

If CreatedBug doesn't exist, the code will execute int(''), which will raise a ValueError. However, we'll actually always have CreatedBug since the rules for specifying a list of columns are that Cassandra will return rows with *any* of the columns. Since we're only specifying the one, we'll only get rows with the CreatedBug column.

review: Approve

« Back to merge proposal