Daisy

Merge lp://staging/~brian-murray/daisy/bugs-to-crash-sig into lp://staging/daisy

  1. bugs-to-crash-sig
  2. Merge into trunk
Proposed by Brian Murray
Status: Merged
Merged at revision: 284
Proposed branch: lp://staging/~brian-murray/daisy/bugs-to-crash-sig
Merge into: lp://staging/daisy
Diff against target: 72 lines (+39/-0)
3 files modified
daisy/schema.py (+4/-0)
tools/build_bugs_to_crash_sigs.py (+32/-0)
tools/import_bugs.py (+3/-0)
To merge this branch: bzr merge lp://staging/~brian-murray/daisy/bugs-to-crash-sig
Reviewer Review Type Date Requested Status
Evan (community) Approve
Review via email: mp+155876@code.staging.launchpad.net

Description of the change

This creates a BugToCrashSignatures column family so that one will be able to find the crash signatures associated with a particular bug. I've created a tool to do a one time import of only the CreatedBug information from bucketmetadata as I believe that import_bugs.py is a cronjob that is run regular so there is no need to import those.

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

This looks good, save one small issue that I'll fix after merging:

+ bug = int(data.get('CreatedBug', ''))

If CreatedBug doesn't exist, the code will execute int(''), which will raise a ValueError. However, we'll actually always have CreatedBug since the rules for specifying a list of columns are that Cassandra will return rows with *any* of the columns. Since we're only specifying the one, we'll only get rows with the CreatedBug column.

review: Approve
Revision history for this message
Evan (ev) wrote :

Made the additional change as lp:daisy r285. Please feel free to file an RT for this (CC'ing me).

Thanks Brian!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: