Code review comment for lp://staging/~brendan-donegan/ubuntu-autopilot-tests/bug1322064_mtp_transfer

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks for your work.

1. Instead of a 'find' the test should compare the checksums of the files on the device (before the copy) and the host (after the copy). This way you'll validate that the file has not been corrupted during the transfer.

2. You shouldn't hardcode the name of the device. IIRC mtp uses the productId found in the information of the USB bus to which the device is connected and these informations are returned by the device itself.
You can get it directly from the device with the following command:

phablet@ubuntu-phablet:~$ getprop ro.product.model
Nexus 4

review: Needs Fixing

« Back to merge proposal