Merge lp://staging/~brendan-donegan/ubuntu-autopilot-tests/bug1322064_mtp_transfer into lp://staging/ubuntu-autopilot-tests/ubuntu-experience-tests

Proposed by Brendan Donegan
Status: Work in progress
Proposed branch: lp://staging/~brendan-donegan/ubuntu-autopilot-tests/bug1322064_mtp_transfer
Merge into: lp://staging/ubuntu-autopilot-tests/ubuntu-experience-tests
Diff against target: 15 lines (+10/-0)
1 file modified
ubuntu_experience_tests/tests/mtp/test_mtp_transfer.py (+10/-0)
To merge this branch: bzr merge lp://staging/~brendan-donegan/ubuntu-autopilot-tests/bug1322064_mtp_transfer
Reviewer Review Type Date Requested Status
Jean-Baptiste Lallement Needs Fixing
Ubuntu Testcase Admins Pending
Review via email: mp+225454@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-07-03.

Description of the change

MTP transfer test

To post a comment you must log in.
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks for your work.

1. Instead of a 'find' the test should compare the checksums of the files on the device (before the copy) and the host (after the copy). This way you'll validate that the file has not been corrupted during the transfer.

2. You shouldn't hardcode the name of the device. IIRC mtp uses the productId found in the information of the USB bus to which the device is connected and these informations are returned by the device itself.
You can get it directly from the device with the following command:

phablet@ubuntu-phablet:~$ getprop ro.product.model
Nexus 4

review: Needs Fixing
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

s/instead of/after the 'find'/ because the find is required to locate the file.

Unmerged revisions

24. By Brendan Donegan

Add test_mtp_transfer.py

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches