Code review comment for lp://staging/~brendan-donegan/checkbox/story810_plainbox_multiple_whitelists

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This looks good. It would be somewhat better if we could move to using the whitelist qualifier (and perhaps other qualifiers) and the support code defined in applogic.py. The code in checkbox.py is the older version of that code (the one now in applogic.py) and is somewhat more messy.

I'm +1 to merge this but if you can, try porting plainbox/impl/commands/checkbox.py to use applogic.py features.

Thanks
ZK

review: Approve

« Back to merge proposal