Merge lp://staging/~brendan-donegan/checkbox/story810_plainbox_multiple_whitelists into lp://staging/checkbox
Proposed by
Brendan Donegan
| Status: | Merged |
|---|---|
| Approved by: | Zygmunt Krynicki |
| Approved revision: | 2196 |
| Merged at revision: | 2204 |
| Proposed branch: | lp://staging/~brendan-donegan/checkbox/story810_plainbox_multiple_whitelists |
| Merge into: | lp://staging/checkbox |
| Diff against target: |
98 lines (+34/-15) 2 files modified
plainbox/plainbox/impl/commands/checkbox.py (+17/-14) plainbox/plainbox/impl/test_box.py (+17/-1) |
| To merge this branch: | bzr merge lp://staging/~brendan-donegan/checkbox/story810_plainbox_multiple_whitelists |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zygmunt Krynicki (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
We want to be able to play around with multiple whitelists, so this branch adds the ability to pass more than one whitelist on the command line. It also changes to logic of the job selection so that jobs are executed in whitelist order.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks good. It would be somewhat better if we could move to using the whitelist qualifier (and perhaps other qualifiers) and the support code defined in applogic.py. The code in checkbox.py is the older version of that code (the one now in applogic.py) and is somewhat more messy.
I'm +1 to merge this but if you can, try porting plainbox/
Thanks
ZK