Code review comment for lp://staging/~brendan-donegan/checkbox/plainbox_autostart

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

You need the pre-start script / end script section to mkdir /var/cache/plainbox

19 +script
20 + exec plainbox sru /var/cache/plainbox/submission.xml
21 +end script

There is no need to put this into a script section

if we're not passing the secure_id I'd like to put a keyword before the fallback file.

Please modify it to say --fallback=/var/cache/plainbox/submission.xml

32 +Exec=sudo plainbox sru /tmp/submission.xml

Likeweise

« Back to merge proposal