Checkbox

Merge lp://staging/~brendan-donegan/checkbox/plainbox_autostart into lp://staging/checkbox

plainbox_autostart
Merge into trunk

Proposed by Brendan Donegan on 2013-03-26

Status:	Merged
Approved by:	Brendan Donegan on 2013-04-11
Approved revision:	2020
Merged at revision:	2040
Proposed branch:	lp://staging/~brendan-donegan/checkbox/plainbox_autostart
Merge into:	lp://staging/checkbox
Diff against target:	38 lines (+29/-0) 2 files modified plainbox/plainbox/data/plainbox.conf (+19/-0) plainbox/plainbox/data/plainbox.desktop (+10/-0)
To merge this branch:	bzr merge lp://staging/~brendan-donegan/checkbox/plainbox_autostart
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Brendan Donegan (community)		Approve on 2013-04-11
Zygmunt Krynicki (community)	2013-03-26	Needs Fixing on 2013-03-26
Review via email: mp+155502@code.staging.launchpad.net

Description of the change

This merge adds the necessary file for starting plainbox automatically when the system boots.

lp://staging/~brendan-donegan/checkbox/plainbox_autostart updated on 2013-03-26

2013. By Brendan Donegan on 2013-03-26: Add autostart file for plainbox.

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2013-03-26:

+Exec=plainbox -w /usr/share/checkbox/data/whitelists/sru.whitelist

This is obviously not right

If this is about SRU run then we need to run:

$ plainbox sru $secure_id /tmp/fallback.xml

(I wonder how we get the $secure_id there )

If this is not about SRU run then I'd just add 'run' command and perhaps save that somewhere

review: Needs Fixing

lp://staging/~brendan-donegan/checkbox/plainbox_autostart updated on 2013-04-09

2014. By Brendan Donegan on 2013-04-08: Rename plainbox-autostart.desktop to plainbox.desktop and change command to plainbox sru
2015. By Brendan Donegan on 2013-04-08: Rename upstart file to conf
2016. By Brendan Donegan on 2013-04-09: Merge from trunk
2017. By Brendan Donegan on 2013-04-09: Add submission file path to commands

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2013-04-09:

Hope everything looks good now!

review: Needs Resubmitting

lp://staging/~brendan-donegan/checkbox/plainbox_autostart updated on 2013-04-09

2018. By Brendan Donegan on 2013-04-09: Add sudo to command in plainbox.desktop autostart file
2019. By Brendan Donegan on 2013-04-09: Remove variables RUN and USER from upstart job

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2013-04-09:

Better?

review: Needs Resubmitting

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2013-04-09:

You need the pre-start script / end script section to mkdir /var/cache/plainbox

19 +script
20 + exec plainbox sru /var/cache/plainbox/submission.xml
21 +end script

There is no need to put this into a script section

if we're not passing the secure_id I'd like to put a keyword before the fallback file.

Please modify it to say --fallback=/var/cache/plainbox/submission.xml

32 +Exec=sudo plainbox sru /tmp/submission.xml

Likeweise

lp://staging/~brendan-donegan/checkbox/plainbox_autostart updated on 2013-04-09

2020. By Brendan Donegan on 2013-04-09: Misc changes to upstart and autostart files to make things work better

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2013-04-10:

It looks okay now. Let's change plainbox sru to accept keyword --fallback= argument and make $secure_id argument optional by using the config stuff I wrote in another branch.

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2013-04-11:

Okay, let's get this show on the road

review: Approve