Merge lp://staging/~brendan-donegan/checkbox/bug1084601 into lp://staging/checkbox
Proposed by
Brendan Donegan
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Zygmunt Krynicki | ||||
Approved revision: | 1866 | ||||
Merged at revision: | 1880 | ||||
Proposed branch: | lp://staging/~brendan-donegan/checkbox/bug1084601 | ||||
Merge into: | lp://staging/checkbox | ||||
Diff against target: |
406 lines (+184/-51) 3 files modified
debian/changelog (+5/-0) jobs/bluetooth.txt.in (+15/-1) jobs/suspend.txt.in (+164/-50) |
||||
To merge this branch: | bzr merge lp://staging/~brendan-donegan/checkbox/bug1084601 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Approve | ||
Brendan Donegan (community) | Needs Resubmitting | ||
Review via email: mp+142852@code.staging.launchpad.net |
Description of the change
This branch adds a couple of checks before running commands which depend on Bluetooth working. One is to check if the hardware is hard blocked and provide a warning - the subsequent attempt to test will fail. The second is to check if the hardware is soft blocked and again provide a warning, but this time try and unblock it. There is also a short delay after the unblock as most Bluetooth chips take a few seconds to reinitialise (running the test with no delay was exhibiting failures)
To post a comment you must log in.
10:24 < zyga> brendand: looking at your MP
10:24 < zyga> brendand: were you intending to fail the test if bluetooth is hard blocked?
10:25 < zyga> brendand: also, I have this feeling that the rate of repetition in that job warrants a small refactoring to a shell script
10:25 < brendand> zyga, hmm yeah, that's a fair point
10:26 < brendand> zyga, for the hard block, i'd rather just say it's hard block and then let it run and fail, which it probably will