Code review comment for lp://staging/~brendan-donegan/checkbox/bug1084601

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

11:02 < zyga> brendand: I found a bug in your MP
11:02 < zyga> brendand: and something else that's wrong as well, digging deeper
11:13 < zyga> brendand: there's a bug in the shell code
11:13 < zyga> but shell is not parsed here so it should _not_ break
11:14 < zyga> brendand: the actual error is caused by parsing two job entries as one
11:14 < zyga> brendand: so all kinds of weird text gets interpreted as python expression
11:15 < zyga> brendand: this comes from
11:15 < zyga> Failed to parse resource program for job <JobDefinition name:'suspend/bluetooth_detect_after_suspend' plugin:'shell'> from <Origin
              filename:'/home/zyga/.cache/tarmac/branches/checkbox/trunk/jobs/suspend.txt.in' line_start:496 line_end:518>
11:15 < zyga> I'm trying to figure out exactly why this happens, the text looks fine to me
11:17 < zyga> ehhh
11:17 < zyga> ok
11:17 < zyga> I see it
11:17 < zyga> brendand: line 502 in suspend.txt.in
11:17 < zyga> brendand: remove the leading space
11:17 < zyga> brendand: and I'll get the extra debug features as a patch
11:18 < zyga> brendand: also you've missed echo in subsequent line in the shell

review: Needs Fixing

« Back to merge proposal