Code review comment for lp://staging/~bregma/frame/add-xorg-server-depenency
Revision history for this message
| Stephen M. Webb (bregma) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
Without the change I made you can't even build it with a new server. Building with --enable-xi2 requires the xorg-server-dev package (or its -devel equivalent for RPMs) to be present. The build should fail at the configuration stage with a helpful message, not at the compile stage with a cryptic one.
I'm not sure what version is required, but I can guarantee the version specified works.
It is wrong for an upstream package to depend on downstream debian packaging in order to build from source.