Merge lp://staging/~bregma/frame/add-xorg-server-depenency into lp://staging/frame

Oh! Nice catch - we want it to work on slackware, too. :-)

This isn't technically the correct way to do it. libXi checks the XInput version supported by the server at run time. So, there should be a runtime check for XInput 2.1 and a debian packaging check as we have it. But we can still build utouch-frame with an old xorg-server.

Without the change I made you can't even build it with a new server. Building with --enable-xi2 requires the xorg-server-dev package (or its -devel equivalent for RPMs) to be present. The build should fail at the configuration stage with a helpful message, not at the compile stage with a cryptic one.

I'm not sure what version is required, but I can guarantee the version specified works.

It is wrong for an upstream package to depend on downstream debian packaging in order to build from source.

If the source fails to build without a specific version of xserver-xorg-dev, then there's probably something wrong. Can you paste the output of a build failure somewhere and provide the versions of the packages installed?

As for debian packaging, I meant that for the debian package of utouch-frame we must specify the correct runtime depends on the xserver. However, we shouldn't need a build depends on any specific version of xorg-server.

I think I was fixating on the wrong part of the issue. The patch requires a specific version of the xserver, but it should be agnostic to the version. One should be able to build the package on maverick if the x11proto-input-dev and libXi packages from natty are installed, for example.

What I wrote before was wrong. The only change to the patch needed is the removal of the version check on xorg-server.