Code review comment for lp://staging/~brad-marshall/charms/trusty/ceilometer-agent/add-nrpe-checks

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Hey Brad, thanks for the submission!
I know this is similar to the NRPE code submissions for other charms, however a few comments.

- Please fix the unit tests as they are failing
- Additionally, new code has 0 unit test coverage

I'm not overly familiar with how the NRPE stuff works, but HA support is being added to the ceilometer charm which one of the services (ceilometer-central-agent) is running in an active/standby mode. Since this code monitors all the services, what are the impacts when n-1 nodes are reporting this service as down?

review: Needs Fixing

« Back to merge proposal