Merge lp://staging/~brad-marshall/charms/trusty/ceilometer-agent/add-nrpe-checks into lp://staging/~openstack-charmers-archive/charms/trusty/ceilometer-agent/trunk

UOSCI bot says:
charm_lint_check #1122 trusty-ceilometer-agent for brad-marshall mp242041
    LINT OK: passed

LINT Results (max last 5 lines):
INFO:root:Workspace dir: /var/lib/jenkins/workspace/charm_lint_check
INFO:root:Reading file: Makefile
INFO:root:Searching for: ['@flake8']
INFO:root:command: make -f Makefile lint
  W: metadata name (ceilometer-agent) must match directory name (trusty-ceilometer-agent) exactly for local deployment.

Full lint test output: http://paste.ubuntu.com/9066692/
Build: http://10.98.191.181:8080/job/charm_lint_check/1122/

UOSCI bot says:
charm_unit_test #956 trusty-ceilometer-agent for brad-marshall mp242041
    UNIT FAIL: unit-test failed

UNIT Results (max last 5 lines):
  hooks/ceilometer_utils 43 4 91% 99-102
  TOTAL 126 33 74%
  Ran 11 tests in 0.132s
  FAILED (errors=3)
  make: *** [test] Error 1

Full unit test output: http://paste.ubuntu.com/9066693/
Build: http://10.98.191.181:8080/job/charm_unit_test/956/

UOSCI bot says:
charm_amulet_test #464 trusty-ceilometer-agent for brad-marshall mp242041
    AMULET FAIL: amulet-test missing

AMULET Results (max last 5 lines):
INFO:root:Workspace dir: /var/lib/jenkins/workspace/charm_amulet_test
INFO:root:Reading file: Makefile
INFO:root:Searching for: ['@juju test']
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/9066694/
Build: http://10.98.191.181:8080/job/charm_amulet_test/464/

UOSCI bot says:
charm_lint_check #1246 trusty-ceilometer-agent for brad-marshall mp242041
    LINT OK: passed

LINT Results (max last 5 lines):
INFO:root:Reading file: Makefile
INFO:root:Searching for: ['@flake8']
INFO:root:command: make -f Makefile lint
  W: metadata name (ceilometer-agent) must match directory name (trusty-ceilometer-agent) exactly for local deployment.
  I: Categories are being deprecated in favor of tags. Please rename the "categories" field to "tags".

Full lint test output: http://paste.ubuntu.com/9281277/
Build: http://10.98.191.181:8080/job/charm_lint_check/1246/

UOSCI bot says:
charm_unit_test #1080 trusty-ceilometer-agent for brad-marshall mp242041
    UNIT FAIL: unit-test failed

UNIT Results (max last 5 lines):
  hooks/ceilometer_utils 43 4 91% 99-102
  TOTAL 126 33 74%
  Ran 11 tests in 0.105s
  FAILED (errors=3)
  make: *** [test] Error 1

Full unit test output: http://paste.ubuntu.com/9281279/
Build: http://10.98.191.181:8080/job/charm_unit_test/1080/

UOSCI bot says:
charm_amulet_test #549 trusty-ceilometer-agent for brad-marshall mp242041
    AMULET FAIL: amulet-test missing

AMULET Results (max last 5 lines):
INFO:root:Workspace dir: /var/lib/jenkins/workspace/charm_amulet_test
INFO:root:Reading file: Makefile
INFO:root:Searching for: ['@juju test']
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/9281368/
Build: http://10.98.191.181:8080/job/charm_amulet_test/549/

Hey Brad, thanks for the submission!
I know this is similar to the NRPE code submissions for other charms, however a few comments.

- Please fix the unit tests as they are failing
- Additionally, new code has 0 unit test coverage

I'm not overly familiar with how the NRPE stuff works, but HA support is being added to the ceilometer charm which one of the services (ceilometer-central-agent) is running in an active/standby mode. Since this code monitors all the services, what are the impacts when n-1 nodes are reporting this service as down?

My mistake - this is on the ceilometer-agent, which doesn't have high availability - that's going into the ceilometer charm itself.

This branch is now superseded as I've taken the branch and updated it in light of the additional nrpe support that has been added to charm-helper. nrpe support has now landed in the devel charm and will be moved to stable this week