Code review comment for ~brad-figg/+git/kteam-tools:cranky-config-variable
Revision history for this message
| Brad Figg (brad-figg) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
5466644
demo site
(Get the code!)
Another option would be to fix launchpad so that it helped with merge proposals instead of making the process cumbersome. The fact that I have to remove myself from review is silly, it shouldn’t put me there by default. It should also default to the repo from which the branch was created rather than make me add that information. It should also start defaulting to showing git repositories when I go to the “code” section of a project.
But, it is what it is and I’ll try to remember to remove myself as a reviewer.
Brad
From: <email address hidden> <email address hidden> on behalf of Cory Todd <email address hidden>
Date: Wednesday, December 14, 2022 at 6:47 AM
To: Brad Figg <email address hidden>
Subject: Re: [Merge] ~brad-figg/
External email: Use caution opening links or attachments
Okay, I'll check back on the resubmit.
Side note on creating Launchpad merge proposals, I think this (and the other two) have you listed as a reviewer for some reason. This means that once we apply and push these patches, this UI won't show a "merged" status. You will need to either leave a comment with "Approve" selected from the review dropdown box or you could remove yourself from the reviewers list. Either option should work.
--
https:/
You are the owner of ~brad-figg/
Launchpad-
Launchpad-
Launchpad-
Launchpad-Branch: ~brad-figg/