Merge ~brad-figg/+git/kteam-tools:cranky-config-variable into ~canonical-kernel/+git/kteam-tools:master

Proposed by Brad Figg
Status: Needs review
Proposed branch: ~brad-figg/+git/kteam-tools:cranky-config-variable
Merge into: ~canonical-kernel/+git/kteam-tools:master
Diff against target: 81 lines (+14/-12)
3 files modified
cranky/crl/config.py (+9/-6)
ktl/tracking_bug2.py (+1/-2)
stable/create-kernel-tasks (+4/-4)
Reviewer Review Type Date Requested Status
Cory Todd (community) Needs Fixing
Brad Figg Pending
Review via email: mp+433810@code.staging.launchpad.net

This proposal supersedes a proposal from 2022-11-24.

Description of the change

The commit message says it all.

To post a comment you must log in.
Revision history for this message
Cory Todd (corytodd) wrote :

Looks like this absorbed #433807 regarding the SRU board. Comments left inline for those proposed changes.

Other commentary inline.

review: Needs Fixing
Revision history for this message
Brad Figg (brad-figg) wrote :

I'll resubmit this MP. Yes, it looks like I combined it with another MP.

Revision history for this message
Cory Todd (corytodd) wrote :

Okay, I'll check back on the resubmit.

Side note on creating Launchpad merge proposals, I think this (and the other two) have you listed as a reviewer for some reason. This means that once we apply and push these patches, this UI won't show a "merged" status. You will need to either leave a comment with "Approve" selected from the review dropdown box or you could remove yourself from the reviewers list. Either option should work.

Revision history for this message
Brad Figg (brad-figg) wrote :

Another option would be to fix launchpad so that it helped with merge proposals instead of making the process cumbersome. The fact that I have to remove myself from review is silly, it shouldn’t put me there by default. It should also default to the repo from which the branch was created rather than make me add that information. It should also start defaulting to showing git repositories when I go to the “code” section of a project.

But, it is what it is and I’ll try to remember to remove myself as a reviewer.

Brad

From: <email address hidden> <email address hidden> on behalf of Cory Todd <email address hidden>
Date: Wednesday, December 14, 2022 at 6:47 AM
To: Brad Figg <email address hidden>
Subject: Re: [Merge] ~brad-figg/+git/kteam-tools:cranky-config-variable into ~canonical-kernel/+git/kteam-tools:master
External email: Use caution opening links or attachments

Okay, I'll check back on the resubmit.

Side note on creating Launchpad merge proposals, I think this (and the other two) have you listed as a reviewer for some reason. This means that once we apply and push these patches, this UI won't show a "merged" status. You will need to either leave a comment with "Approve" selected from the review dropdown box or you could remove yourself from the reviewers list. Either option should work.
--
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcode.launchpad.net%2F~brad-figg%2F%2Bgit%2Fkteam-tools%2F%2Bmerge%2F433810&amp;data=05%7C01%7Cbfigg%40nvidia.com%7C2d0035cccef5497ab36b08dadde22c2a%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638066260725442087%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=WE9UAAHLRrSavH6gvJjXJ9CR2EeDzIod1d1se10E7mg%3D&amp;reserved=0
You are the owner of ~brad-figg/+git/kteam-tools:cranky-config-variable.

Launchpad-Message-Rationale: Owner
Launchpad-Message-For: brad-figg
Launchpad-Notification-Type: code-review
Launchpad-Branch: ~brad-figg/+git/kteam-tools:cranky-config-variable

Revision history for this message
Jose Ogando Justo (joseogando) :

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches