Code review comment for lp://staging/~bcsaller/juju-gui/routing-hash-query

Revision history for this message
Benjamin Saller (bcsaller) wrote :

Reviewers: mp+168351_code.launchpad.net,

Message:
Please take a look.

Description:
Better Hash/QS support in router

`parse`, `url` and `combine` deal more gracefully with hash and qs url
options. In the case of combine the incoming url replaces any existing
values in the hash and qs portions of the URL as might be expected.
(This
is rather than some artificial merge policy for example).

https://code.launchpad.net/~bcsaller/juju-gui/routing-hash-query/+merge/168351

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/9830046/

Affected files:
   A [revision details]
   M app/assets/javascripts/ns-routing-app-extension.js
   M test/test_routing.js

« Back to merge proposal