Merge lp://staging/~bcsaller/juju-gui/routing-hash-query into lp://staging/juju-gui/experimental

Reviewers: mp+168351_code.launchpad.net,

Message:
Please take a look.

Description:
Better Hash/QS support in router

`parse`, `url` and `combine` deal more gracefully with hash and qs url
options. In the case of combine the incoming url replaces any existing
values in the hash and qs portions of the URL as might be expected.
(This
is rather than some artificial merge policy for example).

https://code.launchpad.net/~bcsaller/juju-gui/routing-hash-query/+merge/168351

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/9830046/

Affected files:
   A [revision details]
   M app/assets/javascripts/ns-routing-app-extension.js
   M test/test_routing.js

LGTM with a concern about the hash parsing to test/check on please.

https://codereview.appspot.com/9830046/diff/1/app/assets/javascripts/ns-routing-app-extension.js
File app/assets/javascripts/ns-routing-app-extension.js (right):

https://codereview.appspot.com/9830046/diff/1/app/assets/javascripts/ns-routing-app-extension.js#newcode111
app/assets/javascripts/ns-routing-app-extension.js:111: var match =
url.match(/#(\w+)([?$])?/);
Can you test that this matches anchor tags with - in them? I don't
recall if \w will work for that. In our case, we've 'namespaced' our
anchors in our tabs code #bws-configuration for instance.

Since there's only one hash per url can we just directly check
location.hash and let the browser do the logic?

https://codereview.appspot.com/9830046/

LGTM, with one question about using a regex over split, largely for my
own edification.

Thanks for this branch, Ben.

https://codereview.appspot.com/9830046/diff/1/app/assets/javascripts/ns-routing-app-extension.js
File app/assets/javascripts/ns-routing-app-extension.js (right):

https://codereview.appspot.com/9830046/diff/1/app/assets/javascripts/ns-routing-app-extension.js#newcode111
app/assets/javascripts/ns-routing-app-extension.js:111: var match =
url.match(/#(\w+)([?$])?/);
Is this actually better than just splitting on '#' much as getQS splits
on '?' Provided Rick's concerns are addressed, I don't know that it
matters, but regexing seems overkill for this.

https://codereview.appspot.com/9830046/

Please take a look.

https://codereview.appspot.com/9830046/