Code review comment for lp://staging/~axlrose112/midori/restful-client-extension

Revision history for this message
Cris Dywan (kalikiana) wrote :

I think, if all you're using from Gee is ArrayList, I would prefer not using it. An optional dependency would require the restful client to be also optional in a counter-intuitive way, and it's not clear right now what else we would generally want to use from Gee, making it worthwhile as a mandatory dependency.
So I'm not generically opposed to a new dep, just right now it seems borderline unnecessary.

How about just using GenericArray<string?> here? Or if it's not enough we can still have our own ArrayList-esque API if it has an advantage you care about.

Also, you've got media herald changes in here, please merge your branch with trunk and clean those out.

review: Needs Fixing

« Back to merge proposal