Merge lp://staging/~axlrose112/midori/restful-client-extension into lp://staging/midori
Proposed by
axlrose112
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~axlrose112/midori/restful-client-extension |
| Merge into: | lp://staging/midori |
| Diff against target: |
1107 lines (+1043/-0) (has conflicts) 4 files modified
CMakeLists.txt (+20/-0) configure (+2/-0) extensions/restful-client.vala (+1007/-0) extensions/webmedia-now-playing.vala (+14/-0) Text conflict in CMakeLists.txt Text conflict in extensions/webmedia-now-playing.vala |
| To merge this branch: | bzr merge lp://staging/~axlrose112/midori/restful-client-extension |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Cris Dywan | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
improve restful-client extension, users can export and import their datas
To post a comment you must log in.
Unmerged revisions
- 6866. By axlrose112
-
restful client extension: add about dialog and help page
- 6865. By axlrose112
-
restful client extension
- 6864. By axlrose112
-
Url, Projet name and Request name Validation
- 6863. By axlrose112
-
Check url, request bug
- 6862. By axlrose112
-
Use the right indentation
- 6861. By axlrose112
-
Add ZippCast
- 6860. By axlrose112
-
extension:Restful client
- 6859. By axlrose112
-
Add COUB http://
coub.com
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I think, if all you're using from Gee is ArrayList, I would prefer not using it. An optional dependency would require the restful client to be also optional in a counter-intuitive way, and it's not clear right now what else we would generally want to use from Gee, making it worthwhile as a mandatory dependency.
So I'm not generically opposed to a new dep, just right now it seems borderline unnecessary.
How about just using GenericArray<
Also, you've got media herald changes in here, please merge your branch with trunk and clean those out.