Code review comment for lp://staging/~altair-ibn-la-ahad/ubuntu/precise/update-notifier/bug-887650

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Thanks for your work here!

> THIS_VERSION=`grep DISTRIB_RELEASE /etc/lsb-release | egrep -o "[0-9.]*"`
This can be just THIS_VERSION=`lsb_release -sr`.

Also, as I've commented on the bug, I would prefer if this MP was against lp:update-notifier, or at least lp:ubuntu/update-notifier (i.e. raring, not precise).

review: Needs Fixing

« Back to merge proposal