Merge lp://staging/~altair-ibn-la-ahad/ubuntu/precise/update-notifier/bug-887650 into lp://staging/ubuntu/precise/update-notifier

Thanks for your work here!

> THIS_VERSION=`grep DISTRIB_RELEASE /etc/lsb-release | egrep -o "[0-9.]*"`
This can be just THIS_VERSION=`lsb_release -sr`.

Also, as I've commented on the bug, I would prefer if this MP was against lp:update-notifier, or at least lp:ubuntu/update-notifier (i.e. raring, not precise).

First, thanks a bunch for working on this, its a very nice fix and will improvethe usability quite a bit.

Some remarks:
- I would also prefer a MP against lp:update-notifier
- I personally prefer $(command) over `command`

Instead of:
  if [ `echo "$THIS_VERSION < $VERSION_ON_CD" | bc` -eq 1 ]; then
you can use:
  if dpkg --compare-versions "$THIS_VERSION" lt "$VERSION_ON_CD"; then
...

This will work as the version number semantic of a ubuntu/debian package is a superset of the version
numbers of the ubuntu distribution releases and I think its slightly more readable this way.

It would be great if you could tweak the MP to address these small issues and I will be happy to merge
and upload then!

Hello Michael, thanks for you feedback.

Last time I relpied to Dmitry only in the BUG and not here in the MP.

I've already created this new branch

https://code.launchpad.net/~altair-ibn-la-ahad/update-notifier/bug-887650

Did I do that correctly? So I think that step is done. I have also created a MP there. Maybe we can delete this MP somehow, because it is "outdated" ?! Sorry, I am new, maybe I should have changed this MP somehow.

I have also added your new changes to that new branch, so it looks like professional code now :)

http://bazaar.launchpad.net/~altair-ibn-la-ahad/update-notifier/bug-887650/revision/783

> I have also created a MP there. Maybe we can delete this MP somehow, because it is "outdated" ?!
> Sorry, I am new, maybe I should have changed this MP somehow.

You could have used "Resubmit" link when you were creating a new proposal, but now you can only set the status to "Work in progress" to remove it from sponsoring queue.

You can also delete it, but that will also delete all the comments.

I've merged the merge proposal that was submitted upstream with some changes, that diff should be cherry picked for Precise if this should be fixed there. Details regarding the Stable Release Update process can be found at http://wiki.ubuntu.com/StableReleaseUpdates.

If you want to get the fix SRUed to precise, some comments:
- could you use the version of the patch which was using in trunk
- you need to use "" around $mount_point to deal with paths with space in their name
- the bug should be made SRU compliant (https://wiki.ubuntu.com/StableReleaseUpdates)

Could you address those and resubmit the merge request?

Hi,

and thanks for your fiuxes to my fix in the trunk. I have picked the latest version and put it here into the precise branch.

Unfortunatally I don't know what Sebastian means by

- the bug should be made SRU compliant (https://wiki.ubuntu.com/StableReleaseUpdates)

??

Does that mean the bug should be written with that Bug template that I find on https://wiki.ubuntu.com/StableReleaseUpdates ? Because I did not write the bug report and can't edit it.

> Does that mean the bug should be written with that Bug template that I find on https://wiki.ubuntu.com/StableReleaseUpdates ?

Yes.

> Because I did not write the bug report and can't edit it.

Everybody can edit bugs, try https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/887650/+edit.

Also, please use "precise-proposed" instead of "precise" in debian/changelog.

Ignore my previous comment, it's OK to use just "precise".

OK don. Thanks.

Should I also make a branch for Quantal? Because that is where the bug originally came from, so it would actually be fixed for the reporting user.

> Should I also make a branch for Quantal?

Yes, please.