Code review comment for lp://staging/~allenap/launchpad/ui-convert-bug-tracker-3.0-bug-418155-pt2

Revision history for this message
Gavin Panella (allenap) wrote :

On Wed, 02 Sep 2009 07:30:40 -0000
Michael Nelson <email address hidden> wrote:

...
> I just noticed that you removed the colons from the dt's in the
> details portlet. I have no idea what is correct, but I usually just
> do what registry has done (ie. https://launchpad.dev/firefox ). Up
> to you.

Heh, I thought I was being clever! I've added them back in.

...
> > I'd not heard of generic-edit before; it'll be handy for the
> > future. However, I don't think it'll be suitable here because the edit
> > page has some blurb at the beginning, including an explanation of why
> > a particular bug tracker cannot be deleted (which is not static).
>
> Sure - I don't mind either way, but just note that there is an
> extra_info slot on launchpad-form.pt (that is used by
> generic-edit.pt).

Is there a way to define a slot without requiring a template for this
view anyway?

« Back to merge proposal