Merge lp://staging/~allenap/launchpad/ui-convert-bug-tracker-3.0-bug-418155-pt2 into lp://staging/~allenap/launchpad/ui-convert-bug-tracker-3.0-bug-418155

This branch converts the bug tracker edit page, the bug tracker
details and projects portlets, and the remote bug index pages to the
3.0 layout. It also makes some small adjustments to the bug tracker
index page.

*** The parent of this branch is:
*** lp:~allenap/launchpad/ui-convert-bug-tracker-3.0-bug-418155

./bin/test -vvt bug-?tracker

lib/canonical/launchpad/testing/pages.py

  Change the print_table() doctest helper function to only print rows
  if cells are found. I've checked that this does not affect
  print_table()'s use in other tests.

lib/lp/bugs/browser/bugtracker.py

  Add a cancel link to the bug tracker edit view.

lib/lp/bugs/stories/bugtracker/xx-bugtracker-remote-bug.txt

  This test was printing whole pages and relying on ellipsis matching,
  so I've changed parts to use print_location(), print_table() and
  print_feedback_messages() instead.

lib/lp/bugs/stories/bugtracker/xx-bugtracker.txt

  Show the presence of the cancel link from above, change the expected
  wording from the projects portlet, and change the expected
  capitalization from the details portlet. An addition section has
  been added to demonstrate how the contact details are not rendered
  at all if there are none recorded.

lib/lp/bugs/templates/bugtracker-edit.pt

  Conversion to main_side layout. I changed a <ul> to an <ol> because
  <ul>s have been castrated in the new style sheet. I imagine I'll
  have a UI review discussion about this :)

lib/lp/bugs/templates/bugtracker-index.pt

  Changed the layout here a bit, to better work with the new
  breadcrumbs. The <h1> on the page is now simply the bug tracker
  title, and the summary is now introduced with an <h2>.

lib/lp/bugs/templates/bugtracker-portlet-details.pt

  Convert this to use a <dl> instead of <b> and <br> tags (arg!). The
  contact details now only appear if there are some.

lib/lp/bugs/templates/bugtracker-portlet-projects.pt

  Convert this portlet to have the intro text within a <p> and the
  list of projects within a <ul>.

lib/lp/bugs/templates/remotebug-index.pt

  Convert to main_side layout. I've also changed the text on the page
  to, ya know, make sense :)

  I think this page is almost unused. It is not linked to from any
  page in Launchpad as far as I'm aware, and is really just a URL hack
  for use by external bug trackers linking back to Launchpad. Also,
  this page is only rendered if there are 2 or more Launchpad bugs
  watching the remote bug. In other words, for UI review especially,
  please don't agonize over appearance here.

  Having said that, I had a very quick go at adding a breadcrumb for
  this page. However, no breadcrumb was rendered and I couldn't fathom
  why. See <http://pastebin.ubuntu.com/263018/> for the diff if you're
  keen; maybe you can spot something I missed.

To walk through the UI, try:

 * Go to the bug trackers page (for IBugTrackerSet) at
   <https://bugs.launchpad.dev/bugs/bugtrackers>,

 * There's nothing new in this page for this branch, so just click on
   "This Mozilla.prg Bug Tracker" to see its overview page,

 * Look at the portlets. The top portlet replicates some of the info
   that's in the page, but it is used elsewhere in Launchpad so it's
   useful to keep.

 * Click "Change details",

 * This is one place where the details portlet is useful.

 * Use the new cancel link to return to the previous page,

 * Notice the new h1 title and h2 "Summary" heading,

 * Append /42 to the URL and see the remote bug index page, including
   the h2 "Is watched by..." and the new text. I think the text is
   good, but the heading was a tough one. I'm simply still not sure
   exactly how to use the heading slot.

> To walk through the UI, try:

Thanks for providing these walk-throughs... much easier to review! I'll start doing that too.
And sorry for the two 'needs fixing' reviews! The pages really do look great (we initially tried to re-use our soyuz context portlets in the same way), but afaik, it's left-over from 1.0 (or maybe I'm confused at that point - I wasn't around then), but it's not meant to be in the 3.0 side-bar.

>
> * Go to the bug trackers page (for IBugTrackerSet) at
> <https://bugs.launchpad.dev/bugs/bugtrackers>,
>
> * There's nothing new in this page for this branch, so just click on
> "This Mozilla.prg Bug Tracker" to see its overview page,
>
> * Look at the portlets. The top portlet replicates some of the info
> that's in the page, but it is used elsewhere in Launchpad so it's
> useful to keep.

See comments on the first MP. I think it's really 1.0 templates trying to be forced into the 3.0 mold (I tried the same thing with some soyuz pages and got rejected ;) ).

>
> * Click "Change details",
>
> * This is one place where the details portlet is useful.

Well, not really - the only extra information presented in the portlet is not really relevant to the person editing the watch? Otherwise it's just duplicated info, and as mentioned in the previous MP, afaik, isn't the type of content that is meant to go in the side portlet. I'd recommend using main_only for this template, you might even be able to get rid of the template and use generic-edit.pt?

>
> * Use the new cancel link to return to the previous page,

Great!

>
> * Notice the new h1 title and h2 "Summary" heading,

Great! Note that both of these above two points will happen automatically with generic-edit.

>
> * Append /42 to the URL and see the remote bug index page, including
> the h2 "Is watched by..." and the new text. I think the text is
> good, but the heading was a tough one. I'm simply still not sure
> exactly how to use the heading slot.

Yeah, it's been confusing and could change again - but afaik, you've done the right thing for the current rules (ie. this is an +index page, so putting an <h1>context.title</h1> is correct).

I'm not so sure about "Is watched by...". I think this h2 shouldn't be a continuation of a sentance. In fact, I'm not even sure that the h2 is necessary. I know I'm looking at the Remote bug #42 for the Mozilla.org bug tracker, and your overview para tells me exactly what I need to know.

And again, I don't think we can put the context details portlet in the side-bar (it was requested for 1.0 and afaik meant to be removed for 2.0(?) and doesn't belong in the side-bar for 3.0).

On Tue, 01 Sep 2009 11:43:19 -0000
Michael Nelson <email address hidden> wrote:

> Review: Needs Fixing ui
> > To walk through the UI, try:
>
> Thanks for providing these walk-throughs... much easier to review!
> I'll start doing that too. And sorry for the two 'needs fixing'
> reviews! The pages really do look great (we initially tried to
> re-use our soyuz context portlets in the same way), but afaik, it's
> left-over from 1.0 (or maybe I'm confused at that point - I wasn't
> around then), but it's not meant to be in the 3.0 side-bar.

No worries about the needs-fixing. They need fixing! :)

>
> >
> > * Go to the bug trackers page (for IBugTrackerSet) at
> > <https://bugs.launchpad.dev/bugs/bugtrackers>,
> >
> > * There's nothing new in this page for this branch, so just click on
> > "This Mozilla.prg Bug Tracker" to see its overview page,
> >
> > * Look at the portlets. The top portlet replicates some of the info
> > that's in the page, but it is used elsewhere in Launchpad so it's
> > useful to keep.
>
> See comments on the first MP. I think it's really 1.0 templates
> trying to be forced into the 3.0 mold (I tried the same thing with
> some soyuz pages and got rejected ;) ).

Yes, I've removed all the side portlets from all of the bug tracker
pages; they don't make sense anywhere. The navigation menu for the bug
tracker index page remains.

>
> >
> > * Click "Change details",
> >
> > * This is one place where the details portlet is useful.
>
> Well, not really - the only extra information presented in the
> portlet is not really relevant to the person editing the watch?
> Otherwise it's just duplicated info, and as mentioned in the
> previous MP, afaik, isn't the type of content that is meant to go in
> the side portlet. I'd recommend using main_only for this template,
> you might even be able to get rid of the template and use
> generic-edit.pt?

I'd not heard of generic-edit before; it'll be handy for the
future. However, I don't think it'll be suitable here because the edit
page has some blurb at the beginning, including an explanation of why
a particular bug tracker cannot be deleted (which is not static).

>
> >
> > * Use the new cancel link to return to the previous page,
>
> Great!
>
> >
> > * Notice the new h1 title and h2 "Summary" heading,
>
> Great! Note that both of these above two points will happen
> automatically with generic-edit.
>
> >
> > * Append /42 to the URL and see the remote bug index page, including
> > the h2 "Is watched by..." and the new text. I think the text is
> > good, but the heading was a tough one. I'm simply still not sure
> > exactly how to use the heading slot.
>
>
> Yeah, it's been confusing and could change again - but afaik, you've
> done the right thing for the current rules (ie. this is an +index
> page, so putting an <h1>context.title</h1> is correct).
>
> I'm not so sure about "Is watched by...". I think this h2 shouldn't
> be a continuation of a sentance. In fact, I'm not even sure that the
> h2 is necessary. I know I'm looking at the Remote bug #42 for the
> Mozilla.org bug tracker, and your overview para tells me exactly
> what I need to know.

I've rem...

> On Tue, 01 Sep 2009 11:43:19 -0000
> Michael Nelson <email address hidden> wrote:
>
> > Review: Needs Fixing ui
> > > To walk through the UI, try:
> >
> > Thanks for providing these walk-throughs... much easier to review!
> > I'll start doing that too. And sorry for the two 'needs fixing'
> > reviews! The pages really do look great (we initially tried to
> > re-use our soyuz context portlets in the same way), but afaik, it's
> > left-over from 1.0 (or maybe I'm confused at that point - I wasn't
> > around then), but it's not meant to be in the 3.0 side-bar.
>
> No worries about the needs-fixing. They need fixing! :)
>
> >
> > >
> > > * Go to the bug trackers page (for IBugTrackerSet) at
> > > <https://bugs.launchpad.dev/bugs/bugtrackers>,
> > >
> > > * There's nothing new in this page for this branch, so just click on
> > > "This Mozilla.prg Bug Tracker" to see its overview page,
> > >
> > > * Look at the portlets. The top portlet replicates some of the info
> > > that's in the page, but it is used elsewhere in Launchpad so it's
> > > useful to keep.
> >
> > See comments on the first MP. I think it's really 1.0 templates
> > trying to be forced into the 3.0 mold (I tried the same thing with
> > some soyuz pages and got rejected ;) ).
>
> Yes, I've removed all the side portlets from all of the bug tracker
> pages; they don't make sense anywhere. The navigation menu for the bug
> tracker index page remains.

Looks good. I just noticed that you removed the colons from the dt's in the details portlet. I have no idea what is correct, but I usually just do what registry has done (ie. https://launchpad.dev/firefox ). Up to you.

>
> >
> > >
> > > * Click "Change details",
> > >
> > > * This is one place where the details portlet is useful.
> >
> > Well, not really - the only extra information presented in the
> > portlet is not really relevant to the person editing the watch?
> > Otherwise it's just duplicated info, and as mentioned in the
> > previous MP, afaik, isn't the type of content that is meant to go in
> > the side portlet. I'd recommend using main_only for this template,
> > you might even be able to get rid of the template and use
> > generic-edit.pt?
>
> I'd not heard of generic-edit before; it'll be handy for the
> future. However, I don't think it'll be suitable here because the edit
> page has some blurb at the beginning, including an explanation of why
> a particular bug tracker cannot be deleted (which is not static).

Sure - I don't mind either way, but just note that there is an extra_info slot on launchpad-form.pt (that is used by generic-edit.pt).

>
> >
> > >
> > > * Use the new cancel link to return to the previous page,
> >
> > Great!
> >
> > >
> > > * Notice the new h1 title and h2 "Summary" heading,
> >
> > Great! Note that both of these above two points will happen
> > automatically with generic-edit.
> >
> > >
> > > * Append /42 to the URL and see the remote bug index page, including
> > > the h2 "Is watched by..." and the new text. I think the text is
> > > good, but the heading was a tough one. I'm simply still not sure
> > > exactly how to use the heading slot.
> >
> >
> ...

On Wed, 02 Sep 2009 07:30:40 -0000
Michael Nelson <email address hidden> wrote:

...
> I just noticed that you removed the colons from the dt's in the
> details portlet. I have no idea what is correct, but I usually just
> do what registry has done (ie. https://launchpad.dev/firefox ). Up
> to you.

Heh, I thought I was being clever! I've added them back in.

...
> > I'd not heard of generic-edit before; it'll be handy for the
> > future. However, I don't think it'll be suitable here because the edit
> > page has some blurb at the beginning, including an explanation of why
> > a particular bug tracker cannot be deleted (which is not static).
>
> Sure - I don't mind either way, but just note that there is an
> extra_info slot on launchpad-form.pt (that is used by
> generic-edit.pt).

Is there a way to define a slot without requiring a template for this
view anyway?

> On Wed, 02 Sep 2009 07:30:40 -0000
> Michael Nelson <email address hidden> wrote:
>
> ...
> > I just noticed that you removed the colons from the dt's in the
> > details portlet. I have no idea what is correct, but I usually just
> > do what registry has done (ie. https://launchpad.dev/firefox ). Up
> > to you.
>
> Heh, I thought I was being clever! I've added them back in.
>
> ...
> > > I'd not heard of generic-edit before; it'll be handy for the
> > > future. However, I don't think it'll be suitable here because the edit
> > > page has some blurb at the beginning, including an explanation of why
> > > a particular bug tracker cannot be deleted (which is not static).
> >
> > Sure - I don't mind either way, but just note that there is an
> > extra_info slot on launchpad-form.pt (that is used by
> > generic-edit.pt).
>
> Is there a way to define a slot without requiring a template for this
> view anyway?

Erm, good point. I was getting confused - so what I've seen others doing is creating a template that is basically like generic edit, but just fills that slot. For example, look at lp/registry/templates/milestone-edit.pt (ignoring the head_epilogue section there).

Again, I think what you've done is fine - it was just something to be aware of.