Code review comment for lp://staging/~allenap/launchpad/ui-convert-bug-tracker-3.0-bug-418155-pt2

Revision history for this message
Gavin Panella (allenap) wrote :

This branch converts the bug tracker edit page, the bug tracker
details and projects portlets, and the remote bug index pages to the
3.0 layout. It also makes some small adjustments to the bug tracker
index page.

*** The parent of this branch is:
*** lp:~allenap/launchpad/ui-convert-bug-tracker-3.0-bug-418155

./bin/test -vvt bug-?tracker

lib/canonical/launchpad/testing/pages.py

  Change the print_table() doctest helper function to only print rows
  if cells are found. I've checked that this does not affect
  print_table()'s use in other tests.

lib/lp/bugs/browser/bugtracker.py

  Add a cancel link to the bug tracker edit view.

lib/lp/bugs/stories/bugtracker/xx-bugtracker-remote-bug.txt

  This test was printing whole pages and relying on ellipsis matching,
  so I've changed parts to use print_location(), print_table() and
  print_feedback_messages() instead.

lib/lp/bugs/stories/bugtracker/xx-bugtracker.txt

  Show the presence of the cancel link from above, change the expected
  wording from the projects portlet, and change the expected
  capitalization from the details portlet. An addition section has
  been added to demonstrate how the contact details are not rendered
  at all if there are none recorded.

lib/lp/bugs/templates/bugtracker-edit.pt

  Conversion to main_side layout. I changed a <ul> to an <ol> because
  <ul>s have been castrated in the new style sheet. I imagine I'll
  have a UI review discussion about this :)

lib/lp/bugs/templates/bugtracker-index.pt

  Changed the layout here a bit, to better work with the new
  breadcrumbs. The <h1> on the page is now simply the bug tracker
  title, and the summary is now introduced with an <h2>.

lib/lp/bugs/templates/bugtracker-portlet-details.pt

  Convert this to use a <dl> instead of <b> and <br> tags (arg!). The
  contact details now only appear if there are some.

lib/lp/bugs/templates/bugtracker-portlet-projects.pt

  Convert this portlet to have the intro text within a <p> and the
  list of projects within a <ul>.

lib/lp/bugs/templates/remotebug-index.pt

  Convert to main_side layout. I've also changed the text on the page
  to, ya know, make sense :)

  I think this page is almost unused. It is not linked to from any
  page in Launchpad as far as I'm aware, and is really just a URL hack
  for use by external bug trackers linking back to Launchpad. Also,
  this page is only rendered if there are 2 or more Launchpad bugs
  watching the remote bug. In other words, for UI review especially,
  please don't agonize over appearance here.

  Having said that, I had a very quick go at adding a breadcrumb for
  this page. However, no breadcrumb was rendered and I couldn't fathom
  why. See <http://pastebin.ubuntu.com/263018/> for the diff if you're
  keen; maybe you can spot something I missed.

« Back to merge proposal