Code review comment for lp://staging/~allenap/gwacl/storage-create-container

Revision history for this message
Julian Edwards (julian-edwards) wrote :

23 + case resp.StatusCode != http.StatusCreated:
24 + return fmt.Errorf("container %s could not be created", container)

Include resp.Status in the error message to help diagnose faults.

25 + default:
26 + return nil
27 + }
28 + return fmt.Errorf("this should never be reached and is " +
29 + "here purely to satisfy Go's compiler")

Get rid of the default case and just return nil?

review: Approve

« Back to merge proposal