Merge lp://staging/~allenap/gwacl/storage-create-container into lp://staging/gwacl

Proposed by Gavin Panella
Status: Merged
Approved by: Julian Edwards
Approved revision: 42
Merged at revision: 40
Proposed branch: lp://staging/~allenap/gwacl/storage-create-container
Merge into: lp://staging/gwacl
Diff against target: 111 lines (+82/-1)
2 files modified
storage.go (+23/-1)
storage_test.go (+59/-0)
To merge this branch: bzr merge lp://staging/~allenap/gwacl/storage-create-container
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+154573@code.staging.launchpad.net

Commit message

New CreateContainer Storage API method.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

23 + case resp.StatusCode != http.StatusCreated:
24 + return fmt.Errorf("container %s could not be created", container)

Include resp.Status in the error message to help diagnose faults.

25 + default:
26 + return nil
27 + }
28 + return fmt.Errorf("this should never be reached and is " +
29 + "here purely to satisfy Go's compiler")

Get rid of the default case and just return nil?

review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: