Code review comment for lp://staging/~allanlesage/qlbr/initial-searches-data

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Is there any point in deduplicating the criterion and project entries? Other than that, this eeems like a good plan, and I think in the long run replacing load_searches is a good idea.

I also think maybe we should consider modeling all possible search criteria in the API, but that's still out of scope for this, and probably more of a version 2 thing.

« Back to merge proposal