Merge lp://staging/~allanlesage/qlbr/initial-searches-data into lp://staging/qlbr

Proposed by Allan LeSage
Status: Needs review
Proposed branch: lp://staging/~allanlesage/qlbr/initial-searches-data
Merge into: lp://staging/qlbr
Diff against target: 215 lines (+210/-0)
1 file modified
initial_data.json (+210/-0)
To merge this branch: bzr merge lp://staging/~allanlesage/qlbr/initial-searches-data
Reviewer Review Type Date Requested Status
Max Brustkern Pending
Review via email: mp+196196@code.staging.launchpad.net

Commit message

Add an initial fixture of searches.

Description of the change

Don't mean to replace load_searches command, but this has the effect of loading automatically as part of syncdb, and saves a line of fab.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Is there any point in deduplicating the criterion and project entries? Other than that, this eeems like a good plan, and I think in the long run replacing load_searches is a good idea.

I also think maybe we should consider modeling all possible search criteria in the API, but that's still out of scope for this, and probably more of a version 2 thing.

Unmerged revisions

54. By Allan LeSage

Add initial data with searches.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: