Thruk Master Charm

Merge ~alephnull-b/charm-thruk-master:bionic-support into ~nagios-charmers/charm-thruk-master:master

  1. Git
  2. lp:~alephnull-b/charm-thruk-master
  3. bionic-support
  4. Merge into master
Proposed by Alok G Singh
Status: Merged
Approved by: Alok G Singh
Approved revision: 4c80b7d3c1d8e2729958ebac9c64356854dcfcff
Merged at revision: 4c80b7d3c1d8e2729958ebac9c64356854dcfcff
Proposed branch: ~alephnull-b/charm-thruk-master:bionic-support
Merge into: ~nagios-charmers/charm-thruk-master:master
Diff against target: 27 lines (+2/-1)
2 files modified
hooks/services.py (+1/-1)
metadata.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Chris Sanders (community) Approve
Andrea Ieri (community) Needs Fixing
Review via email: mp+362027@code.staging.launchpad.net

Description of the change

Tested bionic support.
Fixes lp#1805101

To post a comment you must log in.
Revision history for this message
Andrea Ieri (aieri) wrote :

looks good, but I think it'd be cleaner to have two separate commits, as the issues fixed are conceptually separate

review: Needs Fixing
Revision history for this message
Chris Sanders (chris.sanders) wrote :

> looks good, but I think it'd be cleaner to have two separate commits, as the
> issues fixed are conceptually separate

While I agree in concept, two lines of change splitting into two one line changes seems a bit much IMO.

review: Approve
Revision history for this message
Chris Sanders (chris.sanders) wrote :

> > looks good, but I think it'd be cleaner to have two separate commits, as the
> > issues fixed are conceptually separate
>
> While I agree in concept, two lines of change splitting into two one line
> changes seems a bit much IMO.

Oh and if a bug is closed it should be linked to the review so it updates when accepted and merged.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches