Code review comment for ~alephnull-b/charm-thruk-master:bionic-support
Revision history for this message
| Chris Sanders (chris.sanders) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
> > looks good, but I think it'd be cleaner to have two separate commits, as the
> > issues fixed are conceptually separate
>
> While I agree in concept, two lines of change splitting into two one line
> changes seems a bit much IMO.
Oh and if a bug is closed it should be linked to the review so it updates when accepted and merged.