Merge lp://staging/~aladin/deja-dup/imap-support into lp://staging/~deja-dup-team/deja-dup/trunk
Proposed by
Lars J.
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Michael Terry | ||||
Proposed branch: | lp://staging/~aladin/deja-dup/imap-support | ||||
Merge into: | lp://staging/~deja-dup-team/deja-dup/trunk | ||||
Diff against target: |
672 lines (+419/-3) (has conflicts) 18 files modified
.bzrignore (+3/-0) AUTHORS (+1/-0) common/Backend.vala (+3/-0) common/BackendIMAP.vala (+171/-0) common/IMAP_Configuration_Helper.vala (+101/-0) common/Makefile.am (+2/-0) data/org.gnome.DejaDup.gschema.xml.in (+35/-0) help/translations/deja-dup-help.pot (+4/-0) po/POTFILES.in (+3/-0) po/POTFILES.skip (+3/-0) widgets/ConfigBool.vala (+1/-1) widgets/ConfigEntry.vala (+2/-1) widgets/ConfigLabelLocation.vala (+1/-0) widgets/ConfigLocation.vala (+9/-0) widgets/ConfigLocationIMAP.vala (+77/-0) widgets/ConfigNumber.vala (+1/-1) widgets/Makefile.am (+1/-0) widgets/WidgetUtils.vala (+1/-0) Text conflict in help/translations/deja-dup-help.pot Contents conflict in po/deja-dup.pot |
||||
To merge this branch: | bzr merge lp://staging/~aladin/deja-dup/imap-support | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Terry | Disapprove | ||
Review via email:
|
Description of the change
This branch implements imap support.
- Pay attention to Duplicity Bug #385495
- po/deja-dup.pot is removed from my branch. Why? I run make update-pot
- The list of known IMAP service providers is hard-coded in common/
To post a comment you must log in.
This looks like a very nice patch. I've been in a conference and haven't had the chance to do a full review, including running it yet. I will soon.
However, do you know if this violates some terms of service with Google? I would find it surprising if they were A-OK with such usage...