Code review comment for lp://staging/~aladin/deja-dup/imap-support

Revision history for this message
Michael Terry (mterry) wrote :

You're right that it doesn't clog the main dropdown. I was talking out loud about if we were to offer a drop down for services, where that list of services should go (in main dropdown or sub dropdown).

I liked a dropdown because since the support of servers was hardcoded, it didn't make much sense to have user enter email address and then say that we had a secret list of servers we supported and their address didn't match it. Easier to just show them the servers we support and then we can know all the parameters for that server from there.

So since it violates TOS, I'm thinking we shouldn't add support for this at all if it can't be done in a user-friendly, well-integrated way.

I do like the patch, and maybe it can be resurrected if things change.

review: Disapprove

« Back to merge proposal