Code review comment for lp://staging/~adeuring/launchpad/bug-596944-browser

Revision history for this message
Curtis Hovey (sinzui) wrote :

The additions to the story test are not a story. If I remove the code, the text does not make sense. If I just read the code in the story, I do not know why an admin is making the change for a project he does not own (either the owner does not have permission or we are masking permission issues--do not use admin when unless only an admin can do the task). Users do not read URLs, they read browser title and page content. I personally cannot see how the change is being tests. I do not think a slow story is needed for these changes.

The change was to a view and I expect TestProductBugConfigurationView to be updated to verify the field is present and mutable by the project owner or bug supervisor. I think you could test for html ids to verify the correct template chunks were rendered
    self.assertIsNot(None, find_tag_by_id(view.render(), 'an-id'))

review: Needs Fixing (code)

« Back to merge proposal